[PATCH] D113320: [clang-format] Address fixme

2021-11-09 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG66336056911e: [clang-format] Address fixme (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113320/new/ https://reviews.llvm.

[PATCH] D113320: [clang-format] Address fixme

2021-11-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113320/new/ https://reviews.llvm.org/D113320 ___ cfe-commits mailing list cfe-com

[PATCH] D113320: [clang-format] Address fixme

2021-11-06 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks updated this revision to Diff 385248. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a reviewer: owenpan. HazardyKnusperkeks added a comment. Dropped braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D113320: [clang-format] Address fixme

2021-11-05 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. Looks okay. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3064-3068 + for (const auto &Node : Line.Tokens) { +for (const auto &ChildNode : Node.Children) + printDebugInfo(ChildNode, "\nChild: "); + } Nit: elide brace

[PATCH] D113320: [clang-format] Address fixme

2021-11-05 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, djasper. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLV