[PATCH] D113319: [clang-format] Improve require handling

2021-11-08 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added a comment. In D113319#3115202 , @MyDeveloperDay wrote: > I feel anything you do here would be an improvement. its probably worth > looking at recent issues logged around this

[PATCH] D113319: [clang-format] Improve require handling

2021-11-08 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I feel anything you do here would be an improvement. its probably worth looking at recent issues logged around this issue at the same time https://bugs.llvm.org/show_bug.cgi?id=52401 https://bugs.llvm.org/show_bug.cgi?id=32165 When I added this support its was ba

[PATCH] D113319: [clang-format] Improve require handling

2021-11-05 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Or am I mistaken and we want to be able to control the line break? Also I would break before struct, class, union, but I would have needed to change the test, and I know that we at least need to talk about in in front. :) template require X class ...

[PATCH] D113319: [clang-format] Improve require handling

2021-11-05 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, krasimir, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before th