Re: [PATCH] D11298: Convert a few classes over to use the new TrailingObjects helper.

2015-08-06 Thread James Y Knight via cfe-commits
jyknight marked 2 inline comments as done. Comment at: lib/AST/Decl.cpp:3122 @@ +3121,3 @@ + void *Buffer = Context.Allocate( + totalSizeToAlloc( + TArgs.size(), Ts.size())); rsmith wrote: > OK, I guessed that might be the reason. Seems like a reaso

Re: [PATCH] D11298: Convert a few classes over to use the new TrailingObjects helper.

2015-08-05 Thread Richard Smith
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks like a really nice cleanup, thanks! Comment at: include/clang/AST/DeclTemplate.h:47-49 @@ -45,3 +46,5 @@ /// derived classes. -class LLVM_ALIGNAS(/*alignof(void*)*/ LLV

Re: [PATCH] D11298: Convert a few classes over to use the new TrailingObjects helper.

2015-08-05 Thread James Y Knight
jyknight marked an inline comment as done. Comment at: include/clang/AST/Decl.h:3620 @@ +3619,3 @@ + public DeclContext, + llvm::TrailingObjects { +protected: rsmith wrote: > I would prefer to see an explicit `private` access specifier here. Done here an