[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

tbaeder added a comment. Herald added a project: All. Hi @qiucf, I'm running into a problem with the testsuite that's caused by this patch. I think the comment from @jsji about newer glibc was never addressed. When running the testsuite on ppc64le with a glibc newer than 2.34, the the warning

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf added a comment. In D112906#3305014 , @jwakely wrote: > In D112906#3304925 , @qiucf wrote: > >> Is that because clang lacks something required by this feature? (for >> example. clang-12 doesn't have `__ibm1

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jwakely added a comment. In D112906#3304925 , @qiucf wrote: > Is that because clang lacks something required by this feature? (for example. > clang-12 doesn't have `__ibm128` and many builtins) If so, clang-14 should > have these fixed. When I implemen

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf added a comment. In D112906#3304340 , @jwakely wrote: >> GCC 12 should have proper support for IEEE-754 compliant 128-bit floating >> point in libstdc++. > > Yes, but it's unconditionally disabled when including the headers with Clang. Is that bec

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jwakely added a comment. > GCC 12 should have proper support for IEEE-754 compliant 128-bit floating > point in libstdc++. Yes, but it's unconditionally disabled when including the headers with Clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5590396d041: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf updated this revision to Diff 402405. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Dr

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

nemanjai added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:50 + if (!SupportIEEEFloat128(D, Triple, Args)) { +if (Arg *A = Args.getLastArg(options::OPT_mabi_EQ)) { + StringRef ABIName = A->getValue(); Seems that this will be le

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 _

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf updated this revision to Diff 399536. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/PPCLinux.cpp clang/lib

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf updated this revision to Diff 399262. qiucf edited the summary of this revision. qiucf added a comment. Also check glibc version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 Files: clang/inclu

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf updated this revision to Diff 398906. qiucf marked 2 inline comments as done. qiucf edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906 Files: clang/include/clang/Ba

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji added inline comments. Comment at: clang/test/Driver/ppc-float-abi-warning.cpp:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang -### -x c++ -target powerpc64le-unknown-linux-gnu %s -mabi=ieeelongdouble + Can we add RUN line to test when we are usin

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf created this revision. qiucf added reviewers: PowerPC, jsji, nemanjai, shchenz. Herald added a subscriber: kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/