[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

2021-10-27 Thread Nico Weber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c10c9d8e800: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects (authored by thakis). Herald added a project: clang. Repository: rG LLVM Gith

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

2021-10-27 Thread Nico Weber via Phabricator via cfe-commits
thakis updated this revision to Diff 382627. thakis added a comment. more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://reviews.llvm.org/D112542 Files: clang/include/clang/AST/StmtObjC.h clang/lib/AST/StmtObjC.cpp Index: clang/lib/AST/StmtObjC.cpp

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

2021-10-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. > Do you think the ObjCAtTryStmt::Create and CreateEmpty methods could be > simplified by using totalSizeToAlloc()? Oh nice. Done :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://reviews.llvm.org/D112542

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

2021-10-27 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice! Do you think the ObjCAtTryStmt::Create and CreateEmpty methods could be simplified by using totalSizeToAlloc()? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://r

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

2021-10-26 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. And make it final while here. No behavior change. https://reviews.llvm.org/D112542 Files: clang/include/clang/AST/StmtObjC.h Index: clang/include/clang/AST/StmtObjC.h