[PATCH] D112100: [clang] Add option to disable -clear-ast-before-backend

2021-10-19 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG063c2f89aa7f: [clang] Add option to disable -clear-ast-before-backend (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D112100: [clang] Add option to disable -clear-ast-before-backend

2021-10-19 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 380847. aeubanks added a comment. use BoolOption td files are very hard to use... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112100/new/ https://reviews.llvm.org/D112100 Files: clang/include/clang/Driver

[PATCH] D112100: [clang] Add option to disable -clear-ast-before-backend

2021-10-19 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good - possible flag def improvement with `BoolOption`. Comment at: clang/include/clang/Driver/Options.td:5317-5319 +def no_clear_ast_before_backend : Flag<["-"],

[PATCH] D112100: [clang] Add option to disable -clear-ast-before-backend

2021-10-19 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. aeubanks added reviewers: hans, dblaikie. Herald added a subscriber: dang. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some downstream users have plugins that -clear-ast-before-backend may affect