[PATCH] D111560: [clang][modules] Cache loads of modules imported by PCH

2021-10-13 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. In D111560#3059128 , @dexonsmith wrote: > LGTM. It'd be nice to split out the move of `ReadModuleNames` into an NFC > prep patch for a cleaner commit history before pushing, but up to you. Committed in prep patch: aae776a5

[PATCH] D111560: [clang][modules] Cache loads of modules imported by PCH

2021-10-13 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG08c8016cfb2a: [clang][modules] Cache loads of modules imported by PCH (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D111560?vs=378945&id=379431#toc Repository: rG LLVM

[PATCH] D111560: [clang][modules] Cache loads of modules imported by PCH

2021-10-12 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. It'd be nice to split out the move of `ReadModuleNames` into an NFC prep patch for a cleaner commit history before pushing, but up to you. Repository: rG LLVM Github Monorepo

[PATCH] D111560: [clang][modules] Cache loads of modules imported by PCH

2021-10-12 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. I implemented the alternative approach, which now seems more straightforward than going through the `ModuleManager` and working with `serialization::ModuleFile`. WDYT @dexonsmith? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l