This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGae27ca9a6783: [PowerPC] PPC backend optimization on
conditional trap intrustions (authored by NeHuang).
Repository:
rG LLVM Github Monorepo
CHANG
amyk accepted this revision.
amyk added a comment.
Thanks for addressing the review comments and answering my question. This LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111434/new/
https://reviews.llvm.org/D111434
_
NeHuang updated this revision to Diff 387652.
NeHuang added a comment.
Addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111434/new/
https://reviews.llvm.org/D111434
Files:
llvm/lib/Target/PowerPC/PPCMIPeephole.cpp
llvm/t
NeHuang marked 7 inline comments as done.
NeHuang added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1020
+// We can only do the optimization for the "reg + reg" form.
+if (!(LiMI1 && (Opcode1 == PPC::LI || Opcode1 == PPC::LI8)))
+
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM. There are some very minor nits that can be addressed on the commit.
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1018
+unsigned Opcode2 = LiMI2->ge
amyk added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1018
+unsigned Opcode2 = LiMI2->getOpcode();
+bool isOperand2Immeidate = MI.getOperand(2).isImm();
+// We can only do the optimization for the "reg + reg" form.
-
NeHuang updated this revision to Diff 385282.
NeHuang marked 3 inline comments as done.
NeHuang added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111434/new/
https://reviews.llvm.org/D111434
Files:
llvm/lib/T
amyk added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1011
+ case PPC::TDI:
+ case PPC::TWI: {
+MachineInstr *LiMIA = getVRegDefOrNull(&MI.getOperand(1), MRI);
nemanjai wrote:
> Seems that we should be able to handle
nemanjai added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1011
+ case PPC::TDI:
+ case PPC::TWI: {
+MachineInstr *LiMIA = getVRegDefOrNull(&MI.getOperand(1), MRI);
Seems that we should be able to handle all 4 in the s
NeHuang added a comment.
gentle ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111434/new/
https://reviews.llvm.org/D111434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
NeHuang added a comment.
gentle ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111434/new/
https://reviews.llvm.org/D111434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
NeHuang updated this revision to Diff 378284.
NeHuang added a comment.
clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111434/new/
https://reviews.llvm.org/D111434
Files:
llvm/lib/Target/PowerPC/PPCMIPeephole.cpp
llvm/test/CodeGen/P
NeHuang created this revision.
NeHuang added reviewers: nemanjai, stefanp, PowerPC.
NeHuang added projects: LLVM, PowerPC.
Herald added subscribers: shchenz, JDevlieghere, kbarton, hiraditya.
NeHuang requested review of this revision.
This patch adds PPC back end optimization to analyze the argume
13 matches
Mail list logo
