This revision was automatically updated to reflect the committed changes.
Closed by commit rG0f00aa502d79: Add no_instrument_function attribute to
Objective C methods as well (authored by hiraditya).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1112
hiraditya updated this revision to Diff 377934.
hiraditya added a comment.
clang-format
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111286/new/
https://reviews.llvm.org/D111286
Files:
clang/include/clang/Basic/Attr.td
clang/test/CodeGen/instrument-objc-method.m
clang/test/Misc/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111286/new/
https://reviews.llvm.org/D111286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
hiraditya updated this revision to Diff 377895.
hiraditya added a comment.
Herald added a subscriber: jdoerfert.
Added SemaObjc test case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111286/new/
https://reviews.llvm.org/D111286
Files:
clang/include/clang/Basic/Attr.td
clang/test/
aaron.ballman added a comment.
CI is currently broken, so there's a test here that needs updating:
https://reviews.llvm.org/harbormaster/unit/view/1389113/
Also, this should have at least one SemaObjC test to demonstrate that we no
longer diagnose this as an unknown attribute in that case.
CH
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111286/new/
https://reviews.llvm.org/D111286
___
cfe-commits mailing list
cfe-commi
hiraditya updated this revision to Diff 377752.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111286/new/
https://reviews.llvm.org/D111286
Files:
clang/include/clang/Basic/Attr.td
clang/test/CodeGen/instrument-objc-method.m
Index: clang/test/CodeGen/instrument-objc-method.m
===
hiraditya updated this revision to Diff 377751.
hiraditya added a comment.
Testcase ready.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111286/new/
https://reviews.llvm.org/D111286
Files:
clang/include/clang/Basic/Attr.td
clang/test/CodeGen/instrument-objc-method.m
Index: clang/
hiraditya added a comment.
Still working on adding the testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111286/new/
https://reviews.llvm.org/D111286
___
cfe-commits mailing list
cfe-commits@lists.
hiraditya created this revision.
hiraditya added a reviewer: rjmccall.
Herald added a reviewer: aaron.ballman.
hiraditya requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
There are several methods where we do not want function instrumentation
10 matches
Mail list logo