This revision was automatically updated to reflect the committed changes.
Closed by commit rG256828689231: [clang] Don't use the AST to display
backend diagnostics (authored by aeubanks).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110665/new/
htt
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Sounds OK to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110665/new/
https://reviews.llvm.org/D110665
___
aeubanks added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110665/new/
https://reviews.llvm.org/D110665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
aeubanks updated this revision to Diff 376024.
aeubanks added a comment.
add comments (including why it's a vector and not an actual map)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110665/new/
https://reviews.llvm.org/D110665
Files:
clang/inc
rnk added inline comments.
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:129
SmallVector LinkModules;
+std::vector>
+ManglingFullSourceLocs;
As David says, this could be a plain hash map, maybe hash_code isn't hashable,
but it must have some w
aeubanks added inline comments.
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:336-337
+ for (auto &F : getModule()->functions()) {
+if (const Decl *FD = Gen->GetDeclForMangledName(F.getName())) {
+ auto Loc = FD->getASTContext().getFullLoc(FD->getLocatio
aeubanks updated this revision to Diff 375958.
aeubanks added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110665/new/
https://reviews.llvm.org/D110665
Files:
clang/include/clang/Basic/DiagnosticFrontendKinds.td
cl
dblaikie added inline comments.
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:336-337
+ for (auto &F : getModule()->functions()) {
+if (const Decl *FD = Gen->GetDeclForMangledName(F.getName())) {
+ auto Loc = FD->getASTContext().getFullLoc(FD->getLocatio
aeubanks created this revision.
aeubanks added reviewers: dblaikie, rnk.
aeubanks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We keep a map from function name to source location so we don't have to
do it via looking up a source location
