[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Thanks, @yaxunl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78b0f3701d44: [HIPSPV][1/4] Refactor HIP tool chain (authored by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

yaxunl added a comment. In D110549#3185409 , @linjamaki wrote: > Assuming this patch is ready to land. @yaxunl, Could you please commit this > patch to the LLVM for us. Thanks. I will test it with our internal CI, then commit it. Repository: rG LLVM

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Assuming this patch is ready to land. @yaxunl, Could you please commit this patch to the LLVM for us. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 __

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 393465. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 392664. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPUtility.cpp:119-133 + // Add MC directives to embed target binaries. We ensure that each + // section and image is 16-byte aligned. This is not mandatory, but + // increases the likelihood of data to be a

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

echristo added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPUtility.cpp:119-133 + // Add MC directives to embed target binaries. We ensure that each + // section and image is 16-byte aligned. This is not mandatory, but + // increases the likelihood of data to be

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

tra added a subscriber: echristo. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPUtility.cpp:119-133 + // Add MC directives to embed target binaries. We ensure that each + // section and image is 16-byte aligned. This is not mandatory, but + // increases

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 __

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 387507. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 381852. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki created this revision. Herald added subscribers: yaxunl, mgorny. linjamaki edited the summary of this revision. linjamaki updated this revision to Diff 375488. linjamaki added a comment. linjamaki edited the summary of this revision. linjamaki added a reviewer: yaxunl. linjamaki published