[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

2021-09-20 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

2021-09-20 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +StackSize)); tianshilei1992 wrote: > Do we wan

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

2021-09-20 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +StackSize)); Do we want to check somewh

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

2021-09-20 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D110108#3010861 , @jdoerfert wrote: > The runtime code is missing, right? Yes, was going to make that a separate patch, also need to fix the LLVM tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

2021-09-20 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. The runtime code is missing, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110108/new/ https://reviews.llvm.org/D110108 ___ cfe-commits mailing list cfe-commits@lists.ll