[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf added a comment. In D109950#3101740 , @rjmccall wrote: > Thanks. @hubert.reinterpretcast, @qiucf, can you verify that other compilers > for PPC follow the logic for `TF` / `TC` that we now have with Elizabeth's > patch? There are three different

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. Thanks. @hubert.reinterpretcast, @qiucf, can you verify that other compilers for PPC follow the logic for `TF` / `TC` that we now have with Elizabeth's patch? There are three different type specifiers (`long double`, `__ibm128`, and `float128_t`) which represent form

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. In D109950#3097652 , @rjmccall wrote: > In D109950#3097544 , @eandrews > wrote: > >> In D109950#3097161 , @rjmccall >> wrote: >> >>> Oh, yes, I

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. In D109950#3097544 , @eandrews wrote: > In D109950#3097161 , @rjmccall > wrote: > >> Oh, yes, I think this should be preserving the old logic there and just >> adding a new clause for e

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. In D109950#3097161 , @rjmccall wrote: > Oh, yes, I think this should be preserving the old logic there and just > adding a new clause for explicit requests for ibm128, right? I think the old logic should be preserved yes. Howev

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. Oh, yes, I think this should be preserving the old logic there and just adding a new clause for explicit requests for ibm128, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.llvm.org/D1099

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. This has changed the behavior for - // Define __complex128 type corresponding to __float128 (as in GCC headers). typedef _Complex float __attribute__((mode(TC))) __complex128; void check() { // CHECK: alloca { fp128, fp128 } <- Fails because alloca { x86

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd11ec6f67e45: [Clang] Enable IC/IF mode for __ibm128 (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.llvm.org/D109950 ___

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf updated this revision to Diff 378561. qiucf added a comment. Add codegen test to show generated type in IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.llvm.org/D109950 Files: clang/lib/Basic/TargetInfo.cpp

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. I agree. It doesn't have to be a CodeGen test, just anything that directly verifies that we get the right type, since I think those calls can succeed due to promotion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

aaron.ballman added a comment. I'd appreciate some codegen tests for the new functionality as well (so we're testing not just "do we accept it" but also "does it work" as well), but this looks correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf updated this revision to Diff 378131. qiucf marked 2 inline comments as done. qiucf added a comment. Split and rebase upon D111391 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.l

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:44 #include "clang/Basic/TargetCXXABI.h" +#include "clang/Basic/TargetInfo.h" #include "clang/Basic/XRayLists.h" It's a shame to have to do this in such a pervasively-included head

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf created this revision. qiucf added reviewers: nemanjai, hubert.reinterpretcast, rjmccall, PowerPC, aaron.ballman. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As for 128-bit floating points on PPC, compiler should have three