[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

2021-09-16 Thread Daniel Rodríguez Troitiño via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe6020b2a4224: [clang][NFC] refactor GlobalMethodPool to encapsulate its map (authored by rmaz, committed by drodriguez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

2021-09-16 Thread Richard Howell via Phabricator via cfe-commits
rmaz updated this revision to Diff 372999. rmaz added a comment. - keep `std::pair`, but move to `GlobalMethodPool::Lists` - add `const` - `val` -> `&&Val` - move comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109898/new/ https://reviews.ll

[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

2021-09-16 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks for splitting this out -- left some comments inline, LGTM after that. Comment at: clang/include/clang/Sema/Sema.h:1422-1427 /// Method Pool - allows efficie

[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

2021-09-16 Thread Richard Howell via Phabricator via cfe-commits
rmaz created this revision. rmaz added reviewers: dexonsmith, manmanren, vsapsai. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This refactor changes the GlobalMethodPool to a class that contains the DenseMap of methods. This is to a