[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

2021-11-26 Thread Daniel Kiss via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG632acec73776: [libunwind][ARM] Handle end of stack during unwind (authored by danielkiss). Herald added projects: libc++abi, libunwind. Herald added 1 blocking reviewer(s): libc++abi. Repository: rG LLV

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

2021-11-26 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. In D109856#3155235 , @danielkiss wrote: > In D109856#3154763 , @mstorsjo > wrote: > >> Looks reasonable

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

2021-11-26 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss added a comment. In D109856#3154763 , @mstorsjo wrote: > Looks reasonable I think. Is this a deficiency in the EHABI implementation > only, i.e. this aspect works as it should in the regular dwarf implementation? Yes, it works on dwarf alread

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

2021-11-25 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Looks reasonable I think. Is this a deficiency in the EHABI implementation only, i.e. this aspect works as it should in the regular dwarf implementation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109856/new/ https://reviews.llvm.org/D109856 __