[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. Thanks for the fixes! My bots are happy now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall added a comment. In D109506#3087055 , @0x1eaf wrote: > I think this should work-around end-to-end test failure on Windows: > > diff --git a/clang-tools-extra/clangd/test/crash.test > b/clang-tools-extra/clangd/test/crash.test > index 1197e1

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I think this should work-around end-to-end test failure on Windows: diff --git a/clang-tools-extra/clangd/test/crash.test b/clang-tools-extra/clangd/test/crash.test index 1197e1ab07c3..68ef54808f09 100644 --- a/clang-tools-extra/clangd/test/crash.test +++ b/clang-

[PATCH] D109506: [clangd] Print current request context along with the stack trace

jansvoboda11 added a comment. Here's another test failure: https://green.lab.llvm.org/green/job/clang-stage1-RA/24998 Can you revert if the fix is not trivial? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109

[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. In D109506#3086214 , @smeenai wrote: > In D109506#3086183 , @thakis wrote: > >> This doesn't build on windows: http://45.33.8.238/win/47615/step_4.txt >> >> Please take a look and revert fo

[PATCH] D109506: [clangd] Print current request context along with the stack trace

uabelho added a comment. Hi, It seems like this patch may cause timeouts. I've seen it myself and also in this bot: http://lab.llvm.org:8011/#/builders/52/builds/11791 When I got the timeout in our downstream CI I think it was the Clangd :: crash.test that had problems. Repository: rG LLVM

[PATCH] D109506: [clangd] Print current request context along with the stack trace

smeenai added a comment. In D109506#3086183 , @thakis wrote: > This doesn't build on windows: http://45.33.8.238/win/47615/step_4.txt > > Please take a look and revert for now if it takes a while to fix. I pushed rGba94b8bdffb4

[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. This doesn't build on windows: http://45.33.8.238/win/47615/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D10

[PATCH] D109506: [clangd] Print current request context along with the stack trace

This revision was automatically updated to reflect the committed changes. Closed by commit rG045695f85cb8: [clangd] Print current request context along with the stack trace (authored by 0x1eaf, committed by sammccall). Changed prior to commit: https://reviews.llvm.org/D109506?vs=379124&id=38214

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall added a comment. In D109506#3059313 , @0x1eaf wrote: > I've instrumented preamble building, but haven't instrumented background > indexing which is outside of `TUScheduler.cpp` and would require exposing > `crashDump*` helpers and preferably m

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. Are there any blockers to landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf marked an inline comment as done. 0x1eaf added a comment. I don't have commit access, so would appreciate if you commit it, thanks! Forgot to mention on Friday: I've instrumented preamble building, but haven't instrumented background indexing which is outside of `TUScheduler.cpp` and wou

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 379124. 0x1eaf added a comment. Updated the AST worker crash handler to avoid `std::string` copy: used a char pointer instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks great, thanks! Happy to commit this for you if you don't have access. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1327 +llvm::errs() << "Signalle

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf marked 9 inline comments as done. 0x1eaf added a comment. I've opted for simulating signals in the unit test on Windows by manually calling the signal handler, and added a list test to test the crash handling integration end-to-end. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 378257. 0x1eaf added a comment. Addressed feedback from the last round of comments. Sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 Files: clang

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall added a comment. This is mostly LG with nits, but I think the code-completion handler is wrong, and the tests as written won't build on windows. In D109506#2992201 , @sammccall wrote: > Oops, forgot one thing: you probably want to instrument t

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I've tried making an integration test in addition to the unit test, but I couldn't find a way to make lit ignore the crashed process exit status: FAIL: Clangd :: crash.test (1049 of 1049) TEST 'Clangd :: crash.test' FAILED S

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 372515. 0x1eaf retitled this revision from "[RFC] Print current request context along with the stack trance in clangd" to "[clangd] Print current request context along with the stack trace". 0x1eaf edited the summary of this revision. 0x1eaf added a comment.