[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

RKSimon added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:17 +files. It reads each input archive file to extract the archived cubin files as +temporary files. These temporary (*.cubin) files are passed to ``nvlink``. + saiislam wrote: > RKSimon

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:17 +files. It reads each input archive file to extract the archived cubin files as +temporary files. These temporary (*.cubin) files are passed to ``nvlink``.

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

RKSimon added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:17 +files. It reads each input archive file to extract the archived cubin files as +temporary files. These temporary (*.cubin) files are passed to ``nvlink``. + @saiislam The "(*.cubin)"

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe15836361cdf: [clang-nvlink-wrapper] Add documentation in clang docs (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam updated this revision to Diff 370559. saiislam marked 14 inline comments as done. saiislam added a comment. 1. Fixed wording as suggested. 2. Replaced hyperlink to generate html, using the :doc: tag as used in other places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with only minor nits from me, thank you! Comment at: clang/docs/ClangNvlinkWrapper.rst:13 + +This tool works as a wrapper over nvlink program. It is requir

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:1 += +Clang Nvlink Wrapper please remove one "=" rst expects alignment Comment at: clang/docs/ClangNvlinkWrapper.rst:52 + Output file gen

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam updated this revision to Diff 370547. saiislam added a comment. typo fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109225/new/ https://reviews.llvm.org/D109225 Files: clang/docs/ClangNvlinkWrapper.rst clang/docs/ReleaseNotes.rst

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:19 + +During linking of heterogenous device archive libraries with an OpenMP program, +the `Clang Offload Bundler `_ hetero

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam updated this revision to Diff 370543. saiislam added a comment. Added MSVC warning fix also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109225/new/ https://reviews.llvm.org/D109225 Files: clang/docs/ClangNvlinkWrapper.rst clang/doc

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam created this revision. saiislam added reviewers: sylvestre.ledru, ye-luo, jdoerfert. Herald added a subscriber: arphaman. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add documentation of clang-nvlink-wrapper t