[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang updated this revision to Diff 370630. weiwang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D109175 Files: clang/lib/Sema/SemaDecl.cpp clang/test/OpenMP/declare_target_messag

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

ABataev added a comment. In D109175#2981054 , @jdoerfert wrote: > In D109175#2980905 , @weiwang wrote: > >> In D109175#2980900 , @jdoerfert >> wrote: >> >>> In D109175#29

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

jdoerfert added a subscriber: ABataev. jdoerfert added a comment. In D109175#2980905 , @weiwang wrote: > In D109175#2980900 , @jdoerfert > wrote: > >> In D109175#2980806

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980900 , @jdoerfert wrote: > In D109175#2980806 , @weiwang wrote: > >> In D109175#2980744 , @jdoerfert >> wrote: >> >>> Why do we nee

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

jdoerfert added a comment. In D109175#2980806 , @weiwang wrote: > In D109175#2980744 , @jdoerfert > wrote: > >> Why do we need this flag, is the absence of -fopenmp-targets not sufficient? > > Just double checked

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980744 , @jdoerfert wrote: > Why do we need this flag, is the absence of -fopenmp-targets not sufficient? Just double checked, this is the full omp related options currently in use: "-fopenmp" "-fopenmp-version=3

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

jdoerfert added a comment. Why do we need this flag, is the absence of -fopenmp-targets not sufficient? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D109175 ___ cfe-

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

wenlei added a comment. In D109175#2980446 , @lebedev.ri wrote: > In D109175#2980333 , @weiwang wrote: > >> Our internal codebase never uses the target directive. Once the deferred >> diags is bypassed, we obser

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980446 , @lebedev.ri wrote: > In D109175#2980333 , @weiwang wrote: > >> Our internal codebase never uses the target directive. Once the deferred >> diags is bypassed, we obse

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

lebedev.ri added a comment. In D109175#2980333 , @weiwang wrote: > Our internal codebase never uses the target directive. Once the deferred > diags is bypassed, we observed 18% e2e build time improvement. Is that with `-fopenmp` or without? That seems,

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. Our internal codebase never uses the target directive. Once the deferred diags is bypassed, we observed 18% e2e build time improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D10

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang created this revision. Herald added subscribers: hoy, dexonsmith, wenlei, dang, guansong, yaxunl. weiwang requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. There are cases where no target c