[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

rjmccall added a comment. Alright, no worries. It was reasonable to ask if this was something we should fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108618/new/ https://reviews.llvm.org/D108618 _

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro abandoned this revision. djtodoro added a comment. In D108618#2968626 , @rjmccall wrote: > Does LLVM model `noinline` as a call-site attribute in the way that would be > necessary to get that effect? Also, are you actually having a problem here

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

rjmccall added a comment. Does LLVM model `noinline` as a call-site attribute in the way that would be necessary to get that effect? Also, are you actually having a problem here, or is this just something you noticed in the code? I'm not sure we can warn about putting the attribute on a declar

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro added a comment. In D108618#2964265 , @rjmccall wrote: > Why do you want to add `noinline` to a function declaration that lacks a > definition? If this won't be used at all I guess the compiler should throw a warning at least. One example come

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

rjmccall added a comment. Why do you want to add `noinline` to a function declaration that lacks a definition? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108618/new/ https://reviews.llvm.org/D108618

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro created this revision. djtodoro added a reviewer: rjmccall. djtodoro added projects: clang, LLVM. djtodoro requested review of this revision. The `CodeGen` is missing to add the `NoInline` attribute to the target of a call, even the declaration has the __attribute__ presented. This fixes