cor3ntin marked 4 inline comments as done.
cor3ntin added inline comments.
Comment at: clang/include/clang/Lex/Lexer.h:702
// Helper functions to lex the remainder of a token of the specific type.
- bool LexIdentifier (Token &Result, const char *CurPtr);
+ bool LexId
cor3ntin updated this revision to Diff 368746.
cor3ntin added a comment.
Fix comments following Aaron's feedback, remove
braces deemed unecessary by the guidelines
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108308/new/
https://reviews.llvm.org/D
aaron.ballman added inline comments.
Comment at: clang/include/clang/Lex/Lexer.h:701
// Helper functions to lex the remainder of a token of the specific type.
+ bool LexIdentifierContinue(Token &Result, const char *CurPtr);
Something like this then?
Repos
cor3ntin added inline comments.
Comment at: clang/include/clang/Lex/Lexer.h:702
// Helper functions to lex the remainder of a token of the specific type.
- bool LexIdentifier (Token &Result, const char *CurPtr);
+ bool LexIdentifierContinue(Token &Result, const char
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a subscriber: rsmith.
aaron.ballman added a comment.
In general, I'm in favor of these changes. They help identify (pun *totally*
intended) where we're improperly expecting ASCII identifiers in places, which
can hopefully be addressed i
cor3ntin added a comment.
@aaron.ballman Let me know what you think.
The PR does not contain new behavior, only renames and refactor the function
lexing identifiers. I ran the build a few times and did not measure performance
differences on my system. The code should behave exactly the same exce
cor3ntin updated this revision to Diff 367326.
cor3ntin added a comment.
Remove file committed accidentally
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108308/new/
https://reviews.llvm.org/D108308
Files:
clang-tools-extra/clang-include-fixer/I
cor3ntin updated this revision to Diff 367325.
cor3ntin added a comment.
Looks better in lower case after all
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108308/new/
https://reviews.llvm.org/D108308
Files:
clang-tools-extra/clang-include-fixer
cor3ntin updated this revision to Diff 367322.
cor3ntin added a comment.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.
Spell ASCII in upper case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108308/new/
https://revie
