[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGebfcd06d4222: [clangd] IncludeCleaner: Mark used headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.l

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377264. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Thank you for the review! Looks much better now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.h:65 SrcMgr::CharacteristicKind FileKind = SrcMgr::C_User; + unsigned ID = std::numeric_limits::max(); // Correspon

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377197. kbobyrev marked 10 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:158 + +std::vector +getUnused(IncludeStructure::HeaderID EntryPoint, sammccall wrote: > sammccall wrote: > > Why are we passing around Inclusions by value? > Sorry, should ha

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:159 +std::vector +getUnused(IncludeStructure::HeaderID EntryPoint, + const IncludeStructure &Structure, EntryPoint is unused Comment at: clang-too

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377158. kbobyrev added a comment. Refactor FileID -> IncludeStructure::HeaderID into a separate function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: cl

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377125. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added a comment. Sorry, I thought i'd sent these comments... Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:158 + +std::vector +getUnused(IncludeStructure::HeaderID EntryPoint, Why are we passing around Inclusions by value?

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377112. kbobyrev added a comment. Rebase on top of landed patches. Ping, @sammccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clang

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376431. kbobyrev added a comment. Tiny refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tool

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376430. kbobyrev added a comment. Fix the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-e

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 376425. kbobyrev added a comment. Rebase on top of main. Now ready for a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/In

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 375154. kbobyrev added a comment. Rebase on top of D110386 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-e

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 375153. kbobyrev added a comment. Prepare for rebase: revert Headers.cpp and Headers.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/cla

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374469. kbobyrev added a comment. Perform the computation in the IncludeStructure::File space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-e

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:61 SrcMgr::CharacteristicKind FileKind = SrcMgr::C_User; + FileID ID; }; Most includes are part of the preamble, so there are two relevant parse actions (preamble, and mainfile-

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374226. kbobyrev added a comment. Make sure FileEntry* is not nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374219. kbobyrev added a comment. Populate Inclusion.ID, add a test (failing for now). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/cla

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev added a comment. Hey, sorry for the gigantic turn around. I still need to cover the code with few tests and polish it a bit more but I've updated the majority of it and pushed to get some early feedback before I do that. Please let me know if you have any concerns/see some problems wit

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374174. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Improve structure, address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D1081

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added a comment. I realize many of the things I'll object to came from my own prototype, sorry about that :-\ I think/hope I gave you some forewarning about this! Comment at: clang-tools-extra/clangd/Headers.h:137 + // Maps including files (from) to included files (

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 367140. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to add some basic tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 ___ cfe-commi

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 366835. kbobyrev added a comment. Nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/clangd/Heade

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Follow-p on D