[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM, but maybe wait for @sidneym feedback, or add as "blocking reviewer". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ htt

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124 + +bool internal_iserror(uptr retval, int *rverrno) { + if (retval == (uptr)-1) { vitalybuka wrote: > sidneym wrote: > > bcain wrote: > > > @sidney

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367027. bcain added a comment. fixed iserror() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake compiler-

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367020. bcain added a comment. Herald added a subscriber: krytarowski. applied `clang-format-diff`, s/long/u32/ for syscall funcs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.or

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:88 +{ + register long r6 __asm__("r6") = n; + register long r0 __asm__("r0") = a; vitalybuka wrote: > should this use u64 like other __internal_syscal

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

vitalybuka added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:94 # include #if defined(__mips64) || defined(__aarch64__) || defined(__arm__) || \ +defined(__hexagon__) || \ please use clang-format versi

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367008. bcain added a comment. added context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake compiler-rt

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

vitalybuka added a comment. The last snapshot uploaded without "arc diff", so it does not show "context" code around, which is inconvenient for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 ___

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

vitalybuka added a comment. In D108083#2949934 , @bcain wrote: > In D108083#2949815 , @vitalybuka > wrote: > >>> We can help create a bot for hexagon-unknown-linux-musl. What's the process? >> >> Thank you. https

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 366995. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake compiler-rt/lib/sanitizer_common/sanitizer_common.

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common (1/8)

bcain updated this revision to Diff 366766. bcain retitled this revision from "add sanitizer support to hexagon" to "[sanitizer] Add hexagon support to sanitizer-common (1/8)". bcain edited the summary of this revision. bcain added a comment. Decomposed to just the sanitizer-common portion. Now