RKSimon added inline comments.
Comment at: llvm/lib/LTO/LTOBackend.cpp:234
+ if (TM)
+TM->setPGOOption(PGOOpt);
@xur Why does TM need a null check - afaict it's already been dereferenced in
the call tree, and will be again below.
Noticed in a scan-build
dexonsmith added inline comments.
Comment at: llvm/lib/CodeGen/MIRSampleProfile.cpp:289
+
+bool MIRProfileLoaderPass::runOnMachineFunction(MachineFunction &MF) {
+ if (!MIRSampleLoader->isValid())
JDevlieghere wrote:
> Why is this outside the `llvm` namespace?
JDevlieghere added inline comments.
Comment at: llvm/include/llvm/CodeGen/MIRSampleProfile.h:59
+MIRSampleLoader(
+std::make_unique(FileName, RemappingFileName)) {
+LowBit = getFSPassBitBegin(P);
You're instantiating a forward-declared typ
hoy added inline comments.
Comment at: llvm/test/CodeGen/X86/fsafdo_test2.ll:3
+; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo
%S/Inputs/fsloader.afdo
+; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo
-show-fs-branchprob -disable-ra-fsprofile-loader=fa
wenlei added inline comments.
Comment at: llvm/test/CodeGen/X86/fsafdo_test2.ll:3
+; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo
%S/Inputs/fsloader.afdo
+; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo
-show-fs-branchprob -disable-ra-fsprofile-loader
lenary added inline comments.
Comment at: llvm/test/CodeGen/X86/fsafdo_test2.ll:3
+; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo
%S/Inputs/fsloader.afdo
+; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo
-show-fs-branchprob -disable-ra-fsprofile-loader
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5fdaaf7fd8f3: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO)
profile loader (authored by xur).
Herald added a project: clang.
Herald added a subscrib
