[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added inline comments. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two" // NOT-AIX: error: unsupported option '-b' fo

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Ettore Tiotto via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41e3ac398c3a: [AIX]: Fix option processing for -b (authored by etiotto). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Ettore Tiotto via Phabricator via cfe-commits
etiotto added inline comments. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two" // NOT-AIX: error: unsupported option '-b'

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Jinsong Ji via Phabricator via cfe-commits
jsji accepted this revision as: jsji. jsji added a comment. LGTM, Thanks. Comment at: clang/test/Driver/Xlinker-args.c:26 // LINUX: "--no-demangle" "-e" "_start" "one" "two" "three" "four" "-z" "five" "-r" {{.*}} "-T" "a.lds" -// AIX: "-b" "one" +// AIX: "-b" "one" "-b" "two

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 __

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Ettore Tiotto via Phabricator via cfe-commits
etiotto updated this revision to Diff 365312. etiotto added a comment. Address code review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp cl

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Ettore Tiotto via Phabricator via cfe-commits
etiotto updated this revision to Diff 365311. etiotto added a comment. Adapting test for -b option processing on AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 Files: clang/lib/Driver/ToolChains/Co

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:271 // Handle reserved library options. -if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx)) +else if (A.getOption().matches(options::OPT_Z_reserved_lib_st

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. Tests please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D107786: [AIX]: Fix option processing for -b

2021-08-09 Thread Ettore Tiotto via Phabricator via cfe-commits
etiotto created this revision. etiotto added reviewers: ZarkoCA, hubert.reinterpretcast, Whitney, cebowleratibm. etiotto added a project: LLVM. etiotto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Code added by D106688