This revision was automatically updated to reflect the committed changes.
Closed by commit rG77b921b870aa: [WebAssembly] Tidy up EH/SjLj options
(authored by aheejin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107685/new/
https://reviews.llvm.or
dschuff accepted this revision.
dschuff added inline comments.
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:449
+ // done in WasmEHPrepare pass after these IR passes, but Wasm SjLj requires
+ // Emscripten libraries and processed together in LowerEmscrip
aheejin added inline comments.
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:449
+ // done in WasmEHPrepare pass after these IR passes, but Wasm SjLj requires
+ // Emscripten libraries and processed together in LowerEmscriptenEHSjLJ pass.
+ if (WasmEnabl
aheejin updated this revision to Diff 368237.
aheejin marked 3 inline comments as done.
aheejin added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107685/new/
https://reviews.llvm.org/D107685
Files:
clang/test/CodeGe
dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:278
+// Two SjLj modes cannot be turned on at the same time
+assert(!(EnableEmSjLj
aheejin updated this revision to Diff 368203.
aheejin added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add `-wasm-enable-eh`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107685/new/
https://reviews.llvm.org/D
