ckandeler added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107145/new/
https://reviews.llvm.org/D107145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rG159a26964840: [clangd] Add new semantic token modifier
"virtual" (authored by ckandeler, committed by MaskRay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
ckandeler added a comment.
Can someone please merge this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107145/new/
https://reviews.llvm.org/D107145
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ckandeler updated this revision to Diff 363106.
ckandeler added a comment.
Fixed lit tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107145/new/
https://reviews.llvm.org/D107145
Files:
clang-tools-extra/clangd/SemanticHighlighting.cpp
cla
ckandeler updated this revision to Diff 363031.
ckandeler added a comment.
Extended test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107145/new/
https://reviews.llvm.org/D107145
Files:
clang-tools-extra/clangd/SemanticHighlighting.cpp
c
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
The modifier seems reasonable to me.
The most important cases are callsites (where `virtual`) isn't written. Can you
extend a test to cover some such case?
Repository:
rG LLVM Github
ckandeler created this revision.
ckandeler added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
ckandeler requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This is needed for
