azabaznov added a comment.
Reverted it due too suspicious failing:
error: 'error' diagnostics expected but not seen:
File
/home/tcwg-buildslave/worker/clang-armv7-2stage/llvm/clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl
Line 8: type '__global write_only pipe int ({{(void)?}})' can only b
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd1e4b2575673: [OpenCL] Add support of __opencl_c_pipes
feature macro. (authored by azabaznov).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
azabaznov updated this revision to Diff 362955.
azabaznov added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106748/new/
https://reviews.llvm.org/D106748
Files:
clang/include/clang/Basic/LangOptions.def
clang/lib/Basic/OpenC
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106748/new/
https://reviews.llvm.org/D106748
_
azabaznov updated this revision to Diff 362018.
azabaznov added a comment.
Herald added a subscriber: dexonsmith.
Preserve existing diagnostic with `err_opencl_unknown_type_specifier`, fix
comments for language option
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://re
Anastasia added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154
"'%2' %select{type qualifier|storage class specifier}3">;
+def err_opencl_type_specifier_requires : Error<
+ "%select{type qualifier|storage class specifier}0 '%1' requires "
-
azabaznov added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154
"'%2' %select{type qualifier|storage class specifier}3">;
+def err_opencl_type_specifier_requires : Error<
+ "%select{type qualifier|storage class specifier}0 '%1' requires "
-
Anastasia added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:154
"'%2' %select{type qualifier|storage class specifier}3">;
+def err_opencl_type_specifier_requires : Error<
+ "%select{type qualifier|storage class specifier}0 '%1' requires "
-
azabaznov created this revision.
azabaznov added reviewers: Anastasia, svenvh.
Herald added subscribers: ldrumm, yaxunl.
azabaznov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
'pipe' keyword is introduced in OpenCL C 2.0: so do checks fo
