[PATCH] D106535: [clangd] Use CommandMangler in TestTU

MaskRay added a comment. In D106535#2900728 , @kadircet wrote: > Can you provide a reproducer or build bot failure for the crash Fangrui ? I already provided an internal bug :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

Re: [PATCH] D106535: [clangd] Use CommandMangler in TestTU

Can you provide a reproducer or build bot failure for the crash Fangrui ? On Fri, Jul 23, 2021 at 6:50 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added a comment. > > `[clangd] Get rid of arg adjusters in CommandMangler` can crash > `BuildCompilerInvocation.Drops

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

MaskRay added a comment. `[clangd] Get rid of arg adjusters in CommandMangler` can crash `BuildCompilerInvocation.DropsPlugins`. I am testing `ninja check-clangd` and will push the revert shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1065

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

thakis added a comment. One of your 4 commits in https://github.com/llvm/llvm-project/compare/f86570cd5241...ba5dd945ad91 broke check-clangd on arm macs: http://45.33.8.238/macm1/14648/step_9.txt Please take a look, and revert for now if it takes a while to fix. (And consider spreading out co

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2a6ec8eae75: [clangd] Use CommandMangler in TestTU (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

Re: [PATCH] D106535: [clangd] Use CommandMangler in TestTU

yes that's right. On Thu, Jul 22, 2021 at 12:20 PM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added a comment. > > I guess this is technically untested, but will be covered after D106527 < > https://reviews.llvm.org/D106527>? > > > Repository: > rG LLVM Github Mon

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

sammccall added a comment. I guess this is technically untested, but will be covered after D106527 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106535/new/ https://reviews.llvm.org/D106535

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This makes testing setup