[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

yaxunl added a comment. In D106315#2900882 , @tra wrote: > In D106315#2899928 , @yaxunl wrote: > >> Yes that's possible. However that would require FE to know these functions >> and declare them, whereas the curr

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

tra added a comment. In D106315#2899928 , @yaxunl wrote: > Yes that's possible. However that would require FE to know these functions > and declare them, whereas the current approach leave the concern to the > device library. I was thinking of just add

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44dbbe61060a: [HIP] Preserve ASAN bitcode library functions (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

yaxunl added a comment. In D106315#2898536 , @tra wrote: > LGTM in general. > > One question -- does it have to be a function calling other functions just > for the sake of preserving them? > Can it be a flat array of pointers to the functions you need t

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. One question -- does it have to be a function calling other functions just for the sake of preserving them? Can it be a flat array of pointers to the functions you need to keep arou

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. Address sanitizer passes may generate call of ASAN bitcode library functions after bitcode linking in lld, therefore lld cannot add t