[PATCH] D106191: [clang] Option control afn flag

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/UsersManual.rst:1395 + to be replaced with an approximately equivalent set of instructions + or alternative math function calls.

[PATCH] D106191: [clang] Option control afn flag

erichkeane added a comment. 1 small 'english' question, hopefully Aaron can answer, otherwise LGTM. Comment at: clang/docs/UsersManual.rst:1395 + to be replaced with an approximately equivalent set of instructions + or alternative math function calls. For example, a ``pow(x

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 378277. masoud.ataei added a comment. Update the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst clang/inclu

[PATCH] D106191: [clang] Option control afn flag

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. erichkeane wrote: > masoud.ataei wrote: > > erichkeane wrote: > > > masoud.a

[PATCH] D106191: [clang] Option control afn flag

erichkeane added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. masoud.ataei wrote: > erichkeane wrote: > > masoud.ataei wrote: > > > erichkean

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei marked an inline comment as not done. masoud.ataei added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. erichkeane wrote: > masoud

[PATCH] D106191: [clang] Option control afn flag

erichkeane added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. masoud.ataei wrote: > erichkeane wrote: > > This seems pretty incomplete to me,

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 378005. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst clang/include/clang/Driver/Options.td clang/lib/CodeGen/BackendUtil

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. erichkeane wrote: > This seems pretty incomplete to me, I have no idea what i

[PATCH] D106191: [clang] Option control afn flag

erichkeane added inline comments. Comment at: clang/docs/UsersManual.rst:1393 + + Allow substitution of approximate calculations for functions. + Defaults to ``-fno-approx-func``. This seems pretty incomplete to me, I have no idea what it does from this desc

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 377909. masoud.ataei added a comment. Update the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/docs/UsersManual.rst clang/inclu

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 377904. masoud.ataei added a comment. Description and driver test are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/include/clang/Driver/

[PATCH] D106191: [clang] Option control afn flag

aaron.ballman added a comment. Agreed on the request for description and driver test coverage. I'm also wondering if there should be a release note and documentation because it's lifting a private flag to be a public one. e.g., should we update https://clang.llvm.org/docs/UsersManual.html#contr

[PATCH] D106191: [clang] Option control afn flag

erichkeane added a comment. In D106191#3046757 , @lebedev.ri wrote: > Looks reasonable to me. > @aaron.ballman @erichkeane does it seem complete or are we missing some infra > piece? At least from the CFE's side I think this is complete as far as I can

[PATCH] D106191: [clang] Option control afn flag

lebedev.ri added reviewers: aaron.ballman, erichkeane. lebedev.ri added subscribers: erichkeane, aaron.ballman. lebedev.ri added a comment. Looks reasonable to me. @aaron.ballman @erichkeane does it seem complete or are we missing some infra piece? Comment at: clang/include/cl

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added a comment. Reminder for reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D106191: [clang] Option control afn flag

nemanjai added a comment. Added @jansvoboda11 to the review as it appears he was the one that added the original option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 __

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei marked 4 inline comments as done. masoud.ataei added a comment. Sorry that it took me so long to reply reviews. Thank you for reviewing this patch. Comment at: clang/include/clang/Driver/Options.td:1732-1733 NegFlag>; -def fapprox_func : Flag<["-"], "fapprox-fu

[PATCH] D106191: [clang] Option control afn flag

bmahjour added inline comments. Comment at: clang/include/clang/Driver/Options.td:1732-1733 NegFlag>; -def fapprox_func : Flag<["-"], "fapprox-func">, Group, Flags<[CC1Option, NoDriverOption]>, - MarshallingInfoFlag>, ImpliedByAnyOf<[menable_unsafe_fp_math.KeyPath]>; defm

[PATCH] D106191: [clang] Option control afn flag

lebedev.ri added a comment. FWIW i think this part is fine in principle. Not sure about errno. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 ___ cfe-commits m

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added a comment. In D106191#2966852 , @qiucf wrote: > Making a new option mapped to another float op flag looks reasonable, but is > there any clearer motivation for this? (such as the need for `-Ofast > -fno-approx-func`) This patch https

[PATCH] D106191: [clang] Option control afn flag

qiucf added a comment. Making a new option mapped to another float op flag looks reasonable, but is there any clearer motivation for this? (such as the need for `-Ofast -fno-approx-func`) Comment at: llvm/include/llvm/Target/TargetOptions.h:179 +/// with approximate calcu

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 359454. masoud.ataei added a comment. Remove extra function deceleration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/include/clang/Driver/Opt

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei created this revision. masoud.ataei added reviewers: bmahjour, Whitney, nemanjai, shchenz. masoud.ataei added projects: clang, LLVM. Herald added subscribers: ormris, dang. masoud.ataei requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. Proposing a