This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdb5f100fe4ca: [HIP] Remove workaround in
__clang_hip_runtime_wrapper.h (authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Gi
ashi1 accepted this revision.
ashi1 added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106070/new/
https://reviews.llvm.org/D106070
___
cfe-commits mailing list
cfe-commits@li
JonChesterfield added a comment.
OK from the openmp gpu side as far as I can tell. This is probably another
instance of where we really wanted _OPENMP_TARGET or similar.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106070/new/
https://reviews.llvm.org/D106070
yaxunl added a comment.
Since this is not easily tested with lit tests, I added a test to
llvm-test-suite: https://reviews.llvm.org/D106069
My understanding is that OpenMP no longer uses __clang_hip_runtime_wrapper.h,
so we should be able to remove this workaround.
CHANGES SINCE LAST ACTION
yaxunl created this revision.
yaxunl added reviewers: tra, JonChesterfield, ronl, ashi1.
yaxunl requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
Remove the workaround for -fopenmp in __clang_hip_runtime_wrapper.h
since it causes device fun
