[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 034b94bb7161c64234e4ec35bf49428c3a1f8f0a . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke added a comment. I would appreciate it if you could submit it on my behalf. Thanks a lot! Name: liuke Email: liuke.ge...@bytedance.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://reviews.llvm.org/D105973 ___ cfe-

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for the fix! Do you need me to commit it on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ htt

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke updated this revision to Diff 358835. Sockke added a comment. update to display context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://reviews.llvm.org/D105973 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

MTC accepted this revision. MTC added a comment. This revision is now accepted and ready to land. LGTM, thanks for your cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://reviews.llvm.org/D105973 ___ cfe-commits mailin

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke updated this revision to Diff 358820. Sockke edited the summary of this revision. Sockke added a comment. Thanks for your review! I have run clang/docs/tools/dump_ast_matchers.py to regenerate the documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://r

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

aaron.ballman added a comment. The change looks good to me, but you need to regenerate the documentation manually. You can do so by running clang/docs/tools/dump_ast_matchers.py. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://re

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke created this revision. Sockke added reviewers: ymandel, aaron.ballman, MTC. Sockke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The annotation about ignoringImpCasts is wrong, which will cause misunderstanding. Fix it. Reposito