This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1854db74c549: opencl-c.h: add 3.0 optional extension support
for a few more bits (authored by airlied).
Repository:
rG LLVM Github Monorepo
CHANG
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105858/new/
https://reviews.llvm.org/D105858
_
airlied updated this revision to Diff 364372.
airlied added a comment.
Added a comment on the subgroups difference.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105858/new/
https://reviews.llvm.org/D105858
Files:
clang/lib/Headers/opencl-c-base
Anastasia added inline comments.
Comment at: clang/lib/Headers/opencl-c-base.h:329
#endif // defined(__opencl_c_atomic_scope_all_devices)
-#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups)
+#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) ||
defined(__ope
airlied marked an inline comment as done.
airlied added a comment.
yeah I agree I'll drop those two changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105858/new/
https://reviews.llvm.org/D105858
___
airlied updated this revision to Diff 359166.
airlied added a comment.
leave version checks alone since they are inside the outer extension check.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105858/new/
https://reviews.llvm.org/D105858
Files:
airlied updated this revision to Diff 359114.
airlied added a comment.
fixed up missing cl_khr_subgroups checks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105858/new/
https://reviews.llvm.org/D105858
Files:
clang/lib/Headers/opencl-c-base.h
azabaznov added inline comments.
Comment at: clang/lib/Headers/opencl-c-base.h:329
#endif // defined(__opencl_c_atomic_scope_all_devices)
-#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups)
+#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) ||
defined(__ope
Anastasia added a subscriber: azabaznov.
Anastasia added inline comments.
Comment at: clang/lib/Headers/opencl-c-base.h:329
#endif // defined(__opencl_c_atomic_scope_all_devices)
-#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups)
+#if defined(cl_intel_subgroups) || de
airlied created this revision.
airlied added a project: clang.
Herald added subscribers: ldrumm, Anastasia, yaxunl.
airlied requested review of this revision.
Herald added a subscriber: cfe-commits.
These 3 are fairly simple, pipes, workgroups and subgroups.
Repository:
rG LLVM Github Monorepo
10 matches
Mail list logo