[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57b5f4b2ecc6: [RISCV][Clang] Compute the default target-abi if it's empty. (authored by khchen). Changed prior to commit: https://reviews.llvm.org

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 384981. khchen added a comment. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Fil

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

khchen added a comment. This patch depends on D105168 , Please help to review it if you have time. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 __

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added a comment. Commit message needs rewriting still, but the patch looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 ___ cfe-commits mai

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. This looks good to me, and as Jessica says this patch improves robustness and correctness so it would be great to land it for 13.x. @jrtc27 - I think @khchen has reflected all of your comments, but

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 361568. khchen marked 6 inline comments as done. khchen added a comment. address @jrtc27's comment, thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added a comment. The commit message needs rewriting to reflect the final patch. Also, "Explicitly target-abi encoded in IR is clear than empty target-abi." is wrong, it's not about clarity, it's about robustness and correctness. Comment at: clang/lib/Basic/Targets/RISC

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added inline comments. Comment at: llvm/lib/Support/TargetParser.cpp:341-344 + } + if (ISAInfo.hasExtension("d")) +return "lp64d"; + return "lp64"; makes me feel more comfortable inside, and also is a bit more like the old code where we did explici

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 361264. khchen added a comment. address @jrtc27's comment, thanks! I forget RISCVISAInfo include XLen.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:233 + // Use the explicitly target-feature to compute default ABI. + if (getABI().empty()) { +bool Is64Bit = getTriple().getArch() == llvm::Triple::riscv64; I don't think using the

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:235 +bool Is64Bit = getTriple().getArch() == llvm::Triple::riscv64; +ABI = llvm::RISCV::computeDefaultABIFromArch(ISAInfo, Is64Bit).str(); + } The ISAInfo includes XLen ===