vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:908
+// into subexpressions of Sym.
+Visit(Sym));
}
martong wrote:
> vsavchenko wrote:
> > martong wrote:
> > > Alright. So, this is correct
martong added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:908
+// into subexpressions of Sym.
+Visit(Sym));
}
vsavchenko wrote:
> martong wrote:
> > Alright. So, this is correct because `Visit` boils do
vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:908
+// into subexpressions of Sym.
+Visit(Sym));
}
martong wrote:
> Alright. So, this is correct because `Visit` boils down finally to eithe
martong added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:908
+// into subexpressions of Sym.
+Visit(Sym));
}
Alright. So, this is correct because `Visit` boils down finally to either
`infer(Sym->getTy
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6017cb31bb35: [analyzer][solver] Use all sources of
constraints (authored by vsavchenko).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105436/new/
https://
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
such passes
@
much LLVM
> Performance measurements also show the we are within the same margins.
Great! I'd expect massive constraint solver improvements to actually make
performance //better// bec
vsavchenko added a comment.
I compared issues produced by this patch to the issues produced before that on
all projects from `clang/utils/analyzer/projects`, and didn't find any
difference.
Performance measurements also show the we are within the same margins.
F17774659: photo_2021-07-05 19.39.
vsavchenko created this revision.
vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus,
ASDenysPetrov, manas, RedDocMD.
Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin,
rnkovacs, szepet, baloghadamsoftware.
vsavchenko requested review of this revision.