[PATCH] D105368: Lex: add a callback for `#pragma mark`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24f4c3ebef63: Lex: add a callback for `#pragma mark` (authored by compnerd, committed by Saleem Abdulrasool ). Repository: r

[PATCH] D105368: Lex: add a callback for `#pragma mark`

compnerd updated this revision to Diff 356273. compnerd added a comment. Correct lifetime of data in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105368/new/ https://reviews.llvm.org/D105368 Files: clang/include/clang/Lex/PPCallbacks

[PATCH] D105368: Lex: add a callback for `#pragma mark`

dgoldman added inline comments. Comment at: clang/unittests/Lex/PPCallbacksTest.cpp:119 +SourceLocation Location; +StringRef Trivia; + }; should this be an std::string? not sure of the lifetime guarantees here Repository: rG LLVM Github Monorepo CHA

[PATCH] D105368: Lex: add a callback for `#pragma mark`

compnerd created this revision. compnerd added reviewers: dgoldman, rsmith, aaron.ballman. Herald added subscribers: usaxena95, kadircet, kbarton, nemanjai. compnerd requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. Allow a preprocessor obs