[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG88d93923e665: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp (authored by leonardchan). Repository: rG L

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan added a comment. Will submit around end of day if there's no more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 ___ cfe-commits mailing

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

vitalybuka accepted this revision. vitalybuka added a reviewer: mcgrathr. vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan updated this revision to Diff 352476. leonardchan marked an inline comment as done. leonardchan added a comment. Rebased and formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files:

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse vitalybuka wrote: > leonardchan wrote: > >

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse leonardchan wrote: > leonardchan wrote:

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan updated this revision to Diff 352015. leonardchan marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 Files: compiler-rt/lib/hwasan/hwasan_linux.cpp compile

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan marked an inline comment as not done. leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse --