This revision was automatically updated to reflect the committed changes.
Closed by commit rG157473a58f02: [IR] Simplify createReplacementInstr (authored
by foad).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104124/new/
https://reviews.llvm.org/D1
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104124/new/
https://reviews.llvm.org/D104124
__
foad added reviewers: yaxunl, robertlytton.
foad added a comment.
Given how simple createReplacementInstr is now, this does make me wonder if it
was really worth creating ReplaceConstant.{cpp,h} in the first place.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
foad created this revision.
Herald added subscribers: dexonsmith, hiraditya.
foad requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
NFCI, although the test change shows that ConstantExpr::getAsInstruction
is better than the
