This revision was automatically updated to reflect the committed changes.
Closed by commit rGbbebf38b736a: [analyzer] Refactor StoreSiteFinder and
extract DefaultStoreHandler (authored by vsavchenko).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103644/new/
https://reviews.llvm.org/D103644
___
vsavchenko updated this revision to Diff 351512.
vsavchenko marked 2 inline comments as done.
vsavchenko added a comment.
Fix review remarks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103644/new/
https://reviews.llvm.org/D103644
Files:
clang/
vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2047
+
+// TODO: get rid of it.
+const DeclStmt *DS = nullptr;
NoQ wrote:
> WDYM?
>
> Also maybe downscope it?
I meant that the only client for it is unde
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2047
+
+// TODO: get rid of it.
+const DeclStmt *DS = nullptr;
WDYM?
Also maybe downscope it?
Comment at: clang/lib/StaticAnalyzer/Core/BugRep
vsavchenko updated this revision to Diff 351145.
vsavchenko added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103644/new/
https://reviews.llvm.org/D103644
Files:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter
vsavchenko created this revision.
vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus,
manas, RedDocMD.
Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, rnkovacs, szepet, baloghadamsoftware.
vsavchenko requested review of this revision.
