[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG204014ec7557: [clangd] Fix feature modules to drop diagnostics (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

sammccall accepted this revision. sammccall added a comment. LG, I'm a bit sad to see we're not able to skip much work in the diagnostics-outside-main-file case but that's a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103387/new/

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet updated this revision to Diff 352628. kadircet marked 2 inline comments as done. kadircet added a comment. - Bail out early before filling in diag info - Move isExcluded check into handleDiagnostics, rather than handling it during flushing Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:732 +if (Adjuster) DiagLevel = Adjuster(DiagLevel, Info); sammccall wrote: > If I'm reading this right: > - we previously discarded the diagnostic "quickly" without

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:732 +if (Adjuster) DiagLevel = Adjuster(DiagLevel, Info); If I'm reading this rig

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet updated this revision to Diff 348747. kadircet added a comment. Get rid of LastDiagWasSuppressed state in StoreDiags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103387/new/ https://reviews.llvm.org/D103387 Files: clang-tools-extra/cla

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet updated this revision to Diff 348733. kadircet added a comment. Exit after introducing cleanup function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103387/new/ https://reviews.llvm.org/D103387 Files: clang-tools-extra/clangd/Diagnosti

[PATCH] D103387: [clangd] Fix feature modules to drop diagnostics

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Ignored diagnostics were only c