[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

This revision was automatically updated to reflect the committed changes. Closed by commit rGffb48d48e45c: [clang-format] successive C# attributes cause line breaking issues (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D103307?vs=348495&id=348634#toc Reposito

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

curdeius accepted this revision. curdeius added a comment. LGTM. Comment at: clang/lib/Format/TokenAnnotator.cpp:3529 + return true; +// Break between ] and [ but only when its really 2 attributes. +if (Left.is(TT_AttributeSquare) && Right.is(TT_AttributeSquare) &&

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

MyDeveloperDay updated this revision to Diff 348495. MyDeveloperDay added a comment. Add additional unit test, and an additional check to ensure multiple attributes are broken, while @jbcoe this looks very similar to the original rule, the original rule actually had an || in the expression and n

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

MyDeveloperDay added a comment. In D103307#2786645 , @jbcoe wrote: > Thanks for this! I tried to handle the multiple attributes using the "parsing technique" you used, instead of the "mustBreaking technique" but every time I do this I end up putting a

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

jbcoe accepted this revision. jbcoe added a comment. This revision is now accepted and ready to land. Thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103307/new/ https://reviews.llvm.org/D103307 _

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: jbcoe, krasimir, HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. D74265: [clang-format] Improve handling of C# attributes