[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09b75f480d1d: [clang-format] New BreakInheritanceList style AfterComma (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103204/new/ https://reviews.llvm.org/D103204 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103204/new/ https://reviews.llvm.org/D103204 ___

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

lichray updated this revision to Diff 348424. lichray added a comment. Correct a copy-pasted test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103204/new/ https://reviews.llvm.org/D103204 Files: clang/docs/ClangFormatStyleOptions.rst cl

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

lichray added inline comments. Comment at: clang/include/clang/Format/Format.h:1839 +/// \endcode +BILS_AfterComma }; HazardyKnusperkeks wrote: > Maybe add a comma, so that the next addition will not need to modify this > line? Sure. Repository: r

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

lichray marked an inline comment as done. lichray added a comment. In D103204#2784234 , @MyDeveloperDay wrote: > Adding such a feature like this needs unit tests, it won't be let in without > them, you need to add them to clang/unittest/Format/Format.cp

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

lichray updated this revision to Diff 348423. lichray added a comment. Add tests and update the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103204/new/ https://reviews.llvm.org/D103204 Files: clang/docs/ClangFormatStyleOptions.r

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1839 +/// \endcode +BILS_AfterComma }; Maybe add a comma, so that the next addition will not need to modify this line? Repository: rG LLVM Github Monorepo CH

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Adding such a feature like this needs unit tests, it won't be let in without them, you need to add them to clang/unittest/Format/Format.cpp You also need to update th