[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a comment. Thanks a lot @benshi001! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d4d969e22e: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-series (authored by justinlatimer, committed by benshi001). Changed prior to

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a comment. For the commit message, my name is Justin Latimer and my email is justinlati...@gmail.com. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 _

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer updated this revision to Diff 371176. justinlatimer added a comment. Update target-invalid-cpu-note.c test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 Files: clang/lib/Basic/Targets/A

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a comment. Please tell me your email address which will be shown in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___ cfe-

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a comment. Sorry, I happened to find that the list in `lib/Driver/ToolChains/AVR.cpp` also needs update. {"at90s1200", "", "avr1", 0}, {"attiny11", "", "avr1", 0}, {"attiny12", "", "avr1", 0}, {"attiny15", "", "avr1", 0}, {"attiny28", "", "avr1", 0},

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRDevices.td:515 +def : Device<"attiny1614", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny416", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny816", FamilyXMEGA, ELFArchXMEGA3>; --

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added inline comments. Comment at: llvm/lib/Target/AVR/AVRDevices.td:515 +def : Device<"attiny1614", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny416", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny816", FamilyXMEGA, ELFArchXMEGA3>

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRDevices.td:515 +def : Device<"attiny1614", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny416", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny816", FamilyXMEGA, ELFArchXMEGA3>; --

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a reviewer: benshi001. benshi001 added a comment. I though the test clang/test/Misc/target-invalid-cpu-note.c should also be updated. BTW: What info (especially name and email) would like to see in the commit message ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a subscriber: benshi001. justinlatimer added a comment. @benshi001 would it be possible to get this committed? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 _

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Nope, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a comment. @dylanmckay is there anything else I need to update on this patch? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___ cf

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer updated this revision to Diff 348707. justinlatimer added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add devices into the clang AVR target constant list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o