[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 closed this revision. jansvoboda11 added a comment. Fixed in 28fa77feeb7db46abea1a6699d7a88a02d8dab46 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ htt

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith added a comment. In D102923#3059592 , @teemperor wrote: > This seems to have broken compiling some versions of Foundation/Dispatch with > -fmodules enabled (which breaks the LLDB test suite when it tries to compile > any Objective-C tests). C

[PATCH] D102923: [clang][lex] Remark on search path usage

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. This seems to have broken compiling some versions of Foundation/Dispatch with -fmodules enabled (which breaks the LLDB test suite when it tries to compile any Objective-C tests). Can you

[PATCH] D102923: [clang][lex] Remark on search path usage

This revision was automatically updated to reflect the committed changes. Closed by commit rG444513510999: [clang][lex] Remark on search path usage (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 added a comment. Thanks for the review, I handled the header map case and added tests. I'll commit once the CI passes. Comment at: clang/lib/Lex/HeaderSearch.cpp:473 + // The case where the target file **does not exist** is handled here: + HS.noteLookupUsage(*HS

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 updated this revision to Diff 378922. jansvoboda11 added a comment. Report matched header maps even when target file does not exist, add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews.llvm.org/D102923

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks; I think this was worth it. I like how clean it looks with `-verify` in place. LGTM if you add a couple more header map tests, explained inline. Comment at:

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 updated this revision to Diff 378702. jansvoboda11 added a comment. Add `SourceLocation` to remarks and test with `-verify` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews.llvm.org/D102923 Files: clang/incl

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith added inline comments. Comment at: clang/test/Preprocessor/header-search-user-entries.c:9-11 +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries/a' +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith added inline comments. Comment at: clang/test/Preprocessor/header-search-user-entries.c:9-11 +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries/a' +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 added inline comments. Comment at: clang/test/Preprocessor/header-search-user-entries.c:9-11 +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entries/a' +// CHECK: remark: user-provided search path used: '{{.*}}/header-search-user-entri