[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb12b0ae11f: [WebAssembly] Warn on exception spec for Emscripten EH (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791/new/ https:

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

dschuff accepted this revision. dschuff added a comment. Got it, this makes sense to me too. And since it can be turned off, I'm not too worried about annoying users. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791/new/ https://reviews.llvm.o

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

kripken accepted this revision. kripken added a comment. This revision is now accepted and ready to land. I'm not very familiar with this code, but it looks right, and sgtm to add a warning here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

aheejin added a comment. In D102791#2769892 , @dschuff wrote: > BTW Is there a way to disable this warning? The warning is like test.cpp:3:6: warning: dynamic exception specifications with types are currently ignored in wasm [-Wwasm-exception-spec]

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

dschuff added a comment. BTW Is there a way to disable this warning? Since IIUC this could cause code that was not warning (because it used -fno-exceptions or used emscripten's default of -fignore-exceptions) to now start warning, sometimes that makes users who use -Werror unhappy. ==

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out we have not correctly supp