This revision was automatically updated to reflect the committed changes.
Closed by commit rG8f79203a22d8: [clangd] New ParsingCallback for semantics
changes (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102761/new/
https://r
kadircet added a comment.
> It seems like a lit test for this would be terrible. A ClangdServer one
> should be possible, but I can't quite wrap my head around how to write it.
> (Delivering the PreambleData as a param would make the test easier, you could
> assert that the preamble version was
kadircet updated this revision to Diff 347621.
kadircet marked an inline comment as done.
kadircet added a comment.
- s/onSemanticsMaybeChanged/onPreamblePublished
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102761/new/
https://reviews.llvm.org/D
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
It seems like a lit test for this would be terrible. A ClangdServer one should
be possible, but I can't quite wrap my head around how to write it.
(Delivering the PreambleData as a param
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman, javed.absar.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Previously notific
