Xiangling_L marked an inline comment as done.
Xiangling_L added inline comments.
Comment at: clang/test/Sema/struct-packed-align.c:170
+#elif defined(_AIX)
+// On AIX, [bool, char, short] bitfields have the same alignment as unsigned
+// int.
aaron.ballman wrote:
aaron.ballman added inline comments.
Comment at: clang/test/Sema/struct-packed-align.c:170
+#elif defined(_AIX)
+// On AIX, [bool, char, short] bitfields have the same alignment as unsigned
+// int.
We're not really testing the behavior of `bool` or `short` anywh
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
This LGTM. I've added additional reviewers based on the history of the file in
case they will have comments. Please hold on committing this until tomorrow.
CHA
Xiangling_L updated this revision to Diff 346462.
Xiangling_L added a comment.
Adjusted the testcase so that it also tests the property well on aix;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102715/new/
https://reviews.llvm.org/D102715
Files:
clang/test/Sema/struct-packed-align.c
hubert.reinterpretcast added a comment.
From the comment, it seems the code as-is fails to test the property intended.
It seems we want this:
struct packed_chars {
char a : 8, b : 8, c : 8, d : 4;
char e : 8 __attribute__((packed));
char f : 4, g : 8, h : 8, i : 8;
};
extern in
Xiangling_L updated this revision to Diff 346308.
Xiangling_L added a comment.
Add comments to the block;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102715/new/
https://reviews.llvm.org/D102715
Files:
clang/test/Sema/struct-packed-align.c
Index: clang/test/Sema/struct-packed-ali
Xiangling_L created this revision.
Xiangling_L added reviewers: hubert.reinterpretcast, sfertile, jasonliu,
daltenty.
Xiangling_L requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.o
