kadircet added a comment.
oops, sorry. i thought i've accepted the revision already :D
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102519/new/
https://reviews.llvm.org/D102519
___
cfe-commits mailing l
usaxena95 added a comment.
Did you need any other change ? Didn't realised the revision was not "accepted".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102519/new/
https://reviews.llvm.org/D102519
___
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0e7c7d461df1: [clangd] Set FileSystem for tweaks in Check
tool. (a
usaxena95 updated this revision to Diff 345793.
usaxena95 marked an inline comment as done.
usaxena95 added a comment.
added comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102519/new/
https://reviews.llvm.org/D102519
Files:
clang-tools-e
kadircet added a comment.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/tool/Check.cpp:215
nullptr);
- for (const auto &T :
- prepareTweaks(Selection, Opts.TweakFilter, Opts.FeatureModules)) {
+ auto Tweaks =
+
usaxena95 created this revision.
usaxena95 added a reviewer: kadircet.
Herald added a subscriber: arphaman.
usaxena95 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Tweaks like DefineOutline depend on FS
