[PATCH] D102507: [HIP] Support in device code

2021-07-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102507/new/ https://reviews.llvm.org/D102507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D102507: [HIP] Support in device code

2021-06-25 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D102507#2838981 , @tra wrote: > The key difference between C++ and CUDA/HIP, as implemented in clang, is that > `__host__` and `__device__` attributes are considered during function > overloading in CUDA and HIP, so `__host__

[PATCH] D102507: [HIP] Support in device code

2021-06-24 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. The key difference between C++ and CUDA/HIP, as implemented in clang, is that `__host__` and `__device__` attributes are considered during function overloading in CUDA and HIP, so `__host__ void foo()`, `__device__ void foo()` and `__host__ __device__ void foo()` are three

[PATCH] D102507: [HIP] Support in device code

2021-06-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D102507#2833594 , @ldionne wrote: > In D102507#2830688 , @yaxunl wrote: > >> In D102507#2792087 , @rsmith wrote: >> >>> @ldionne How should we g

[PATCH] D102507: [HIP] Support in device code

2021-06-22 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. In D102507#2830688 , @yaxunl wrote: > In D102507#2792087 , @rsmith wrote: > >> @ldionne How should we go about establishing whether libc++ would be >> prepared to officially support CUDA?

[PATCH] D102507: [HIP] Support in device code

2021-06-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D102507#2792087 , @rsmith wrote: > @ldionne How should we go about establishing whether libc++ would be prepared > to officially support CUDA? Right now, Clang's CUDA support is patching in > attributes onto libc++ functions f

[PATCH] D102507: [HIP] Support in device code

2021-06-01 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. @ldionne How should we go about establishing whether libc++ would be prepared to officially support CUDA? Right now, Clang's CUDA support is patching in attributes onto libc++ functions from the outside, which doesn't seem like a sustainable model. CHANGES SINCE LAST A

[PATCH] D102507: [HIP] Support in device code

2021-05-27 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D102507#2760025 , @tra wrote: > In effect this patch applies `__host__ __device__` to a subset of the > standard library headers and whatever headers *they* happen to include. While > it may happen to work, I'm not at all conf

[PATCH] D102507: [HIP] Support in device code

2021-05-14 Thread Artem Belevich via Phabricator via cfe-commits
tra added a subscriber: rsmith. tra added a comment. In effect this patch applies `__host__ __device__` to a subset of the standard library headers and whatever headers *they* happen to include. While it may happen to work, I'm not at all confident that it does not create interesting issues. C

[PATCH] D102507: [HIP] Support in device code

2021-05-14 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: mgorny. yaxunl requested review of this revision. This patch adds wrapper headers for `` and a few others which is required to support ``. The basic idea is to make template functions defined in these headers h