jansvoboda11 added a comment.
Thanks for the review!
Comment at: clang/include/clang/Frontend/CompilerInstance.h:230-232
- std::shared_ptr getInvocationPtr() {
+ CompilerInvocation &getInvocation() {
assert(Invocation && "Compiler instance has no invocation!");
-retu
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd3fb4b9065e9: [clang][deps] NFC: Report modules'
context hash (authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D10248
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, although I'd slightly prefer the change to CompilerInstance.h be split
out and committed after.
Comment at: clang/include/clang/Frontend/CompilerInstance.h:230
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch eagerly constructs and modifies CompilerInvocation of modular
dependencies in
